Narrow workaround for numpy/numpy#16468

nasa · Sep 7, 2022 · fbe4dce · fbe4dce
1 parent 6ff112f
commit fbe4dce
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/.github/workflows/cibuildwheel.yml b/.github/workflows/cibuildwheel.yml
@@ -41,7 +41,8 @@ jobs:
         env:
           CIBW_ENVIRONMENT_MACOS: F77=gfortran-9 F90=gfortran-9
           # Skip musllinux wheels, which take a long time to build because Numpy must be built from source
-          CIBW_SKIP: '*musllinux*'
+          # Skip pp37-win_* and pp37-macosx_*, because there were never Numpy wheels built for them
+          CIBW_SKIP: '*musllinux* pp37-win_* pp37-macosx_*'
 
       - uses: actions/upload-artifact@v3
         with:

diff --git a/pyproject.toml b/pyproject.toml
@@ -2,8 +2,8 @@
 
 requires = ["setuptools",
             "wheel",
-            # Require numpy>=1.20.3 on Windows due to https://github.com/numpy/numpy/pull/16468
-            "oldest-supported-numpy; python_version>='3.10' or platform_system!='Windows'",
-            "numpy==1.20.3; python_version<'3.10' and platform_system=='Windows'"]
+            # see https://github.com/scipy/oldest-supported-numpy/issues/62
+            "numpy==1.19.0; python_version<='3.8' and platform_system=='Windows' and platform_python_implementation != 'PyPy'",
+            "oldest-supported-numpy; python_version>'3.8' or platform_system!='Windows' or platform_python_implementation == 'PyPy'"]
 
 build-backend = 'setuptools.build_meta'