Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EDSC-4312: Bumping lambda memory for adminGetPreferencesMetrics #1833

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

eudoroolivares2016
Copy link
Contributor

@eudoroolivares2016 eudoroolivares2016 commented Nov 18, 2024

Overview

What is the feature?

Bump memory for the lambda so that it completes in production. The database is large enough in production that as is, the job cannot complete so we aren't getting the page to load. See https://search.earthdata.nasa.gov/admin/preferences-metrics. We know that that at least 256mb was sufficient because we tried this on AWS console and re-ran the lambda. however, bumping this up keeps us from needing to update this again in the near future. Cost is not an issue here this lambda is only run by our internal team sparingly and might reduce costs since the actual execution time will be diminished.

What is the Solution?

Bumping up the resources for this sparingly called lambda function

What areas of the application does this impact?

Admin page aws-lambda memory

Testing

Reproduction steps

  • **Environment for testing:Prod
  • **Collection to test with:N/A
  1. Ensure that on the given environment the lambda function completes with the output of the report on the page https://search.earthdata.nasa.gov/admin/preferences-metrics
  2. Due to the database size the problem exists only in ops but, we should make sure each environment the report continues to work

Attachments

Please include relevant screenshots or files that would be helpful in reviewing and verifying this change.

Checklist

  • I have added automated tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.47%. Comparing base (2dab8bb) to head (e305fe4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1833      +/-   ##
==========================================
+ Coverage   93.46%   93.47%   +0.01%     
==========================================
  Files         770      770              
  Lines       18615    18615              
  Branches     4803     4771      -32     
==========================================
+ Hits        17398    17401       +3     
- Misses       1135     1165      +30     
+ Partials       82       49      -33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@eudoroolivares2016 eudoroolivares2016 merged commit cd4f064 into main Nov 21, 2024
11 checks passed
@eudoroolivares2016 eudoroolivares2016 deleted the EDSC-4312 branch November 21, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants