Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EDSC-2896: Variable names truncated in form view (Earthdata Search) #1831

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

daniel-zamora
Copy link
Contributor

@daniel-zamora daniel-zamora commented Nov 13, 2024

Overview

When variables are too long to be displayed on the ESI access method panel, they were being cut off.

What is the Solution?

Updated edsc-echoforms to allow for horizontal scrolling when appropriate.

What areas of the application does this impact?

Access method panel for ESI when variables are displayed.

Testing

Reproduction steps

  • In prod
  • C1574621139-NSIDC_ECS
  1. Select granules for order
  2. Select ESI access method
  3. Expand variable folders until names are too long and being cut off
  4. Verify horizontal scroll bar is usable.

Attachments

Working

Screenshot 2024-11-13 at 11 55 54 AM

Broken

Screenshot 2024-11-13 at 11 57 07 AM

Checklist

  • I have added automated tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.42%. Comparing base (bba8e6a) to head (3e3b89d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1831   +/-   ##
=======================================
  Coverage   93.42%   93.42%           
=======================================
  Files         770      770           
  Lines       18597    18597           
  Branches     4764     4794   +30     
=======================================
  Hits        17375    17375           
  Misses       1174     1174           
  Partials       48       48           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -130,7 +130,6 @@
"connected-react-router": "^6.9.3",
"core-js": "^3.23.3",
"crypto-browserify": "^3.12.0",
"css-loader": "^6.7.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were these unused or?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe these are leftover webpack depenencies

@daniel-zamora daniel-zamora merged commit a5bd9a9 into main Nov 14, 2024
11 checks passed
@daniel-zamora daniel-zamora deleted the EDSC-2896 branch November 14, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants