Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EDSC-3903: Fix granule highlighting when polygons cross the antimeridian twice #1830

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

macrouch
Copy link
Contributor

Overview

What is the feature?

Our granule outlines are being drawn correctly when polygons cross the antimeridian multiple times, but the highlighting of that granule is wrong. See this page

What is the Solution?

Use the same dividePolygon util that is used for granule outlines in the granule highlighting

What areas of the application does this impact?

Drawing granules on the map

Testing

Hover over the granule on the map or in the results list to draw the granule highlight.

See the incorrect drawing here, https://search.uat.earthdata.nasa.gov/search/granules?p=C1258816710-ASDC_DEV2!C1258816710-ASDC_DEV2&pg[1][a]=1259235357!ASDC_DEV2&pg[1][v]=t&pg[1][id]=PREFIRE_SAT1_2B-ATM_S02_R00_20210101190614_00013.nc&pg[1][gsk]=-start_date&q=C1258816710-ASDC_DEV&tl=1704472317!3!!&lat=6.751072007114942&long=-167.34375&zoom=0

Load that same granule locally here http://localhost:8080/search/granules?p=C1258816710-ASDC_DEV2!C1258816710-ASDC_DEV2&pg[1][v]=t&pg[1][id]=PREFIRE_SAT1_2B-ATM_S02_R00_20210101190614_00013.nc&pg[1][gsk]=-start_date&ee=uat&q=C1258816710-ASDC_DEV&tl=1731348943!3!!&lat=-59.340602465477474&long=-137.25&zoom=0

Attachments

Incorr
Screenshot 2024-11-11 at 9 05 23 PM
ect

Correct
Screenshot 2024-11-11 at 9 05 30 PM

Checklist

  • I have added automated tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.44%. Comparing base (a5bd9a9) to head (55aa2a1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1830      +/-   ##
==========================================
+ Coverage   93.42%   93.44%   +0.01%     
==========================================
  Files         770      770              
  Lines       18597    18597              
  Branches     4788     4785       -3     
==========================================
+ Hits        17375    17378       +3     
+ Misses       1140     1138       -2     
+ Partials       82       81       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@macrouch
Copy link
Contributor Author

Look at screenshot testing in playwright using a zoomed in portion of the polygon

@macrouch macrouch merged commit 901263a into main Nov 14, 2024
11 checks passed
@macrouch macrouch deleted the EDSC-3903 branch November 14, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants