Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EDSC-3946: Pass spatial params to timeline queries #1829

Merged
merged 3 commits into from
Nov 13, 2024
Merged

EDSC-3946: Pass spatial params to timeline queries #1829

merged 3 commits into from
Nov 13, 2024

Conversation

macrouch
Copy link
Contributor

Overview

What is the feature?

Our timeline was not matching the granule results list, because we were not passing spatial search parameters to the timeline search.

What is the Solution?

We were passing the spatial parameters to the search function, but the spatial params were not listed in the permitted parameters, so we just needed to add those values.

What areas of the application does this impact?

Timeline queries when spatial exists

Testing

This page shows a single granule returned, but in PROD it shows a solid green bar

PROD: https://search.earthdata.nasa.gov/search/granules?p=C2105091501-LAADS&pg[0][v]=f&sb[0]=-78.27539%2C38.03269%2C-75.90234%2C39.75445&qt=2023-12-07T01%3A35%3A41.733Z%2C2023-12-07T14%3A24%3A05.488Z&fi=MODIS!VIIRS&as[instrument][0]=MODIS&as[instrument][1]=VIIRS&tl=1701934148!1!!

Local fixed with this PR: http://localhost:8080/search/granules?p=C2105091501-LAADS&pg[0][v]=f&sb[0]=-78.27539%2C38.03269%2C-75.90234%2C39.75445&qt=2023-12-07T01%3A35%3A41.733Z%2C2023-12-07T14%3A24%3A05.488Z&fi=MODIS!VIIRS&as[instrument][0]=MODIS&as[instrument][1]=VIIRS&tl=1701934148!1!!

Attachments

PROD
Screenshot 2024-11-11 at 1 08 02 PM

This PR
Screenshot 2024-11-11 at 1 08 14 PM

Checklist

  • I have added automated tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.42%. Comparing base (273e222) to head (5a7d4a7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1829      +/-   ##
==========================================
- Coverage   93.44%   93.42%   -0.02%     
==========================================
  Files         770      770              
  Lines       18597    18597              
  Branches     4794     4794              
==========================================
- Hits        17378    17375       -3     
- Misses       1137     1141       +4     
+ Partials       82       81       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@macrouch macrouch merged commit bba8e6a into main Nov 13, 2024
11 checks passed
@macrouch macrouch deleted the EDSC-3946 branch November 13, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants