EDSC-4292: Adds label to Harmony orders #1828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macrouch
requested review from
trevorlang,
bnp26,
dpesall,
daniel-zamora,
eudoroolivares2016 and
dmistry1
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1828 +/- ##
===========================================
+ Coverage 70.54% 93.44% +22.89%
===========================================
Files 770 770
Lines 18596 18600 +4
Branches 4766 4799 +33
===========================================
+ Hits 13119 17381 +4262
+ Misses 4946 1136 -3810
+ Partials 531 83 -448 ☔ View full report in Codecov by Sentry. |
macrouch
commented
Nov 9, 2024
dpesall
approved these changes
Nov 11, 2024
Comment on lines
+18
to
+21
| if (process.env.IS_OFFLINE) { | ||
| // When running locally set the pool min to 0 to avoid idle connections | ||
| pool.min = 0 | ||
| } |
There was a problem hiding this comment.
Was this the solution to the sorry, too many clients already error we'd run into locally sometimes?
There was a problem hiding this comment.
Yep. it has been driving me crazy recently, and I've been copying this change to all my branches and I haven't seen it in a while
eudoroolivares2016
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
What is the feature?
Adding two labels to Harmony orders in order for the Harmony team to track EDSC orders and group large orders that we split into multiple Harmony orders.
Also fixed the annoying database problem in dev where we say "sorry, too many clients already" by forcing idle connections to be disconnected.
What areas of the application does this impact?
Harmony orders
Testing
Reproduction steps
Submit a harmony order, check the labels added
Checklist