CCB: 2023.03.23

Items for Discussion

@skliper

DS PR #98 Fix #97, Update UT to handle DS_SEQUENCE_DIGITS configuration

DS PR #99 Fix #93, Remove file age check bug

@jphickey

CS PR #73 Fix #71, table processing fixes

DS PR #101 Fix #100, use generated stubs

FM PR #94 Fix #89, separate msg size verify

HK PR #47 Fix #46, use generated stubs

HK PR #48 Fix #42, use payload structure

HS PR #80 Fix #79, Use payload sub-struct in all messages

HS PR #83 Fix #82, use generated stubs

cFE PR #2259 Fix #2258, add more generic status codes

cFE PR #2263 Fix #2262, separate dispatcher for messages

@thnkslprpt

CF PR #337 Fix #336, Apply consistent Event ID names to common events

CF PR #339 Fix #338, Move 'EID' to the end of Event ID names

CF PR #370 Fix #105, Remove 'dummy' from variable names

CF PR #371 Fix #139, Remove use of message storage in CF_AppData global

CF PR #372 Fix #270, Update CF_ProcessMsg() comment description

CS PR #53 Fix #52, Apply consistent Event ID names to common events

CS PR #68 Fix #67, Combine consecutive, mutually-exclusive status checks

CS PR #70 Fix #69, Simplify CS_AttemptTableReshare

DS PR #61 Fix #60, Apply consistent Event ID names to common events

DS PR #62 Fix #10, Fix nasa/FM#13; Make DS/FM file header sub-types unique

DS PR #86 Fix #85, Change EVS_Register failure from SendEvent to WriteToSysLog

DS PR #88 Fix #87, Combine consecutive, mutually-exclusive status checks

FM PR #60 Fix #59, Apply consistent Event ID names to common events

FM PR #85 Fix #84, Remove superfluous assignments at the top of functions

FM PR #88 Fix #87, Change EVS_Register failure from SendEvent to WriteToSysLog

FM PR #93 Fix #92, Use size_t for 'size' variables

HK PR #27 Fix #26, Apply consistent Event ID names to common events

HK PR #31 Fix #30, Move variables declared mid-function to the top

HK PR #44 Fix #43, Remove use of 'dummy' in test code

HS PR #51 Fix #50, Apply consistent Event ID names to common events

HS PR #78 Fix #77, Combine consecutive, mutually-exclusive status checks

LC PR #46 Fix #45, Apply consistent Event ID names to common events

LC PR #47 Fix #14, Refactor LC_SampleAPs to remove extraneous if statement

LC PR #48 Fix #16, Convert LC state macros to enums

LC PR #50 Fix #49, Move variables declared mid-function to the top

LC PR #54 Fix #53, Remove stray refs to old event type constants

LC PR #68 Fix #36, Refactor LC_TableInit to remove multiple returns

LC PR #78 Fix #77, Add break to default case of switch in LC_VerifyMsgLength

LC PR #80 Fix #79, Combine consecutive, mutually-exclusive status checks

MD PR #37 Fix #36, Apply consistent Event ID names to common events

MD PR #49 Fix #48, Remove unintentionally repeated identical assert

MM PR #51 Fix #50, Apply consistent Event ID names to common events

MM PR #52 Fix #8, Remove unnecessary characters from memory dump event

MM PR #53 Fix #21, Add MM_SegmentBreak() to MM_FillMem()

SC PR #61 Fix #60, Apply consistent Event ID names to common events

SC PR #77 Fix #76, Squash static analysis (CodeQL) uninitialized variable warning

SC PR #79 Fix #78, Split up multiple-variable declaration statements

SC PR #81 Fix #5, Use OS_stat instead of OS_OpenCreate to verify file existence

cFE PR #2170 Fix #2169, Update CI_LAB entry point in cfe_es_startup.scr

cFE PR #2173 Fix #2172, Remove last few uses of sprintf()

cFE PR #2176 Fix #2175, Apply consistent Event ID names to common events

cFE PR #2177 Fix #2004, Update deprecated binary filter constant in Dev Guide

cFE PR #2178 Fix #1510, Add reports for unreported errors in CFE_TBL_EarlyInit()

cFE PR #2179 Fix #1506, Align Table Name reporting in CFE_TBL_Register()

cFE PR #2180 Fix #1517, Reformat do/while loop to while (style change only)

cFE PR #2181 Fix #1539, Remove empty if/endif block

cFE PR #2182 Fix #1472, Replace while loop with single memset

cFE PR #2185 Fix #1450, Remove duplicate status check

cFE PR #2186 Fix #1411, Make EVS_PktPtr parameter in EVS_AddLog() const

cFE PR #2188 Fix #1518, Rename misnomer function name CFE_TBL_NotifyTblUsersOfUpdate()

cFE PR #2189 Fix #1456, Rename CFE_SB_RemovePipeCallback_t to ...backArgs_t

cFE PR #2190 Fix #1471, Rename confusing SB ENBL/DSBL Route Commands

cFE PR #2195 Fix #1545, Refactor CFE_TIME_CalculateUTC to utilize CFE_TIME_CalculateTAI

cFE PR #2198 Fix #1461, Move data lock to inside of if block

cFE PR #2199 Fix #1502, Correct type of ActiveTableFlag variable

cFE PR #2201 Fix #1458, Factor out construction of FullName to reduce code duplication

cFE PR #2211 Fix #2210, Move variables declared mid-function to the top

cFE PR #2212 Fix #1428, Refactor error handling for EVS_GetApplicationInfo()

cFE PR #2221 Fix #2003, Update event type constants in Dev Guide

cFE PR #2235 Fix #1985, Check return value of CFE_ES_PutPoolBuf

cFE PR #2241 Fix #1117, Rename unclear FileWrite EIDs

cFE PR #2246 Fix #1497, Use CFE_TIME_SysTime_t instead of indiv. sec/subsec members

cFE PR #2247 Fix #1332, Resolve compiler warnings re. signedness comparisons

cFE PR #2248 Fix #1449, Factor out common code for bitmask check

cFE PR #2250 Fix #2249, Align mismatched function prototype/implem. parameter name

cFE PR #2261 Fix #2260, Convert CFE_TBL_INFO_TABLE_LOCKED into a negative error code

cFS-GroundSystem PR #233 Fix #218, Update LogOverflowCounter Description

cFS-GroundSystem PR #235 Fix #234, Update incorrect variable descriptions in tlm.txt

cFS-GroundSystem PR #236 Fix #220, Add missing description fields to cfe-es-hk-tlm.txt

ci_lab PR #130 Fix #129, Apply consistent Event ID names to common events

ci_lab PR #131 Fix #52, Add version information to NOOP event

ci_lab PR #132 Fix #96, Check returns from CFE calls during init

elf2cfetbl PR #122 Fix #91, Redo SymbolNames malloc to remove out-of-bounds write

elf2cfetbl PR #123 Fix #85, Add checks for all return values from fseek()

elf2cfetbl PR #124 Fix #86, Check return from chmod

elf2cfetbl PR #125 Fix #87, Check return value of stat()

elf2cfetbl PR #127 Fix #126, Move variables declared mid-function to the top

osal PR #1331 Fix #1330, Move variables declared mid-function to the top

osal PR #1354 Fix #1353, Align mismatched function prototype/implem. parameter names

osal PR #1357 Fix #1356, Remove stray remaining 'goto' in OSAL test code

osal PR #1364 Fix #1109, Remove unimplemented test stub prototype

osal PR #1368 Fix #1107, Remove unreachable branch (superfluous if condition)

osal PR #1377 Fix #958, Convert some UT_GetStubCount to UtAssert_STUB_COUNT

psp PR #380 Fix #379, Align mismatched function prototype/implem. parameter names

psp PR #381 Fix #274, Cleanup and add doxygen for cfe_psp.h

psp PR #383 Fix #382, Replace exit(1) and exit(-1) with EXIT_FAILURE macro

sample_app PR #189 Fix #188, Apply consistent Event ID names to common events

sample_app PR #195 Fix #194, Remove component-specific cFE header #includes

sample_app PR #196 Fix #148, Update add_cfe_tables APP_NAME parameter

sample_app PR #198 Fix #197, Refactor SAMPLE_APP_Init/Process to remove multiple returns

sample_app PR #200 Fix #199, Add test for missing branch in SAMPLE_APP_Process()

sample_app PR #201 Fix #141, Zero out global data structure during initialization

sch_lab PR #134 Fix #133, Remove component-specific cFE header #includes

to_lab PR #134 Fix #133, Apply consistent Event ID names to common events

to_lab PR #146 Fix #145, Refactor mutually exclusive logic in if, else if block