Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Absolute actuators not correctly ignored in position save file #122

Open
JosephBowkett opened this issue Sep 14, 2023 · 3 comments
Open

Comments

@JosephBowkett
Copy link
Collaborator

As discovered by Arthur B, starting and stopping a casah/ros2/fcat node with only absolute platinum actuators causes a bug where a fastcat_saved_positions.yaml file will be created, but nothing placed inside it (because there are no relative encoder actuators) and then the node fails on the next startup because the file does not contain the actuators: field.

The fix is likely to correctly check for (*device)->GetState()->something_something->absolute_encoders == false here: https://github.com/nasa-jpl/fastcat/blob/v0.12.13/src/manager.cc#L945 (paraphrased)

@JosephBowkett
Copy link
Collaborator Author

JosephBowkett commented Sep 14, 2023

Further update, it looks like there is no absolute encoder parameter implemented for GoldActuator or PlatinumActuator

Update: I was reminded that Gold and Platinum derive from Actuator, so should still have the parameter available

@JosephBowkett
Copy link
Collaborator Author

Similar, but not quite the same as #45

@arthur-bouton
Copy link

Any update on this matter? So far, I have to delete the file fastcat_saved_positions.yaml each time I want to restart the fcat node.
Not entirely sure if this is related, but the fcat node is also outputting this warning each time it receives a new command:
fcat.cpp:251 | EVR [WARNING_HI ] Device type does not match for [actuator name]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants