Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gracefully handle build errors in esbuild script #2805

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

lpsinger
Copy link
Member

We have two plugins which each take the metafile as an argument. However, if the build fails, then the metafile arguemnt will not be set. In this case esbuild will print the original and hopefully helpful error message, but also unhelpful error messages about the metafile being undefined. Suppress the latter error messages by checking first that the metafile is defined.

@lpsinger lpsinger requested review from Courey and dakota002 December 16, 2024 17:33
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 6.06%. Comparing base (def8c76) to head (8117a76).
Report is 2 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2805   +/-   ##
=====================================
  Coverage   6.06%   6.06%           
=====================================
  Files        171     171           
  Lines       4334    4334           
  Branches     476     476           
=====================================
  Hits         263     263           
  Misses      4069    4069           
  Partials       2       2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

We have two plugins which each take the metafile as an argument.
However, if the build fails, then the metafile arguemnt will not
be set. In this case esbuild will print the original and hopefully
helpful error message, but also unhelpful error messages about the
metafile being undefined. Suppress the latter error messages by
checking first that the metafile is defined.
@lpsinger lpsinger force-pushed the esbuild-if-metafile branch from 98d37f8 to 8117a76 Compare December 16, 2024 19:22
@dakota002 dakota002 merged commit 960827a into nasa-gcn:main Dec 16, 2024
9 checks passed
@lpsinger lpsinger deleted the esbuild-if-metafile branch December 16, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants