Use builtin Web Fetch; polyfill not needed in Node.js >= 20 #2790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2790 +/- ##
=====================================
Coverage 6.06% 6.06%
=====================================
Files 171 171
Lines 4334 4334
Branches 476 476
=====================================
Hits 263 263
Misses 4069 4069
Partials 2 2 ☔ View full report in Codecov by Sentry. |
Note that we must manually exclude the two polyfill libraries, unidici and @remix-run/web-fetch, because they are not properly tree-shaken.
lpsinger
force-pushed
the
builtin-fetch
branch
from
632cdb1 to
5290626
Compare
dakota002
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that we must manually exclude the two polyfill libraries, unidici and @remix-run/web-fetch, because they are not properly tree-shaken.