Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise 404, not 500, if circularId is not finite #2776

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

lpsinger
Copy link
Member

Fixes the following error:

2024-12-10T16:45:51.373Z	96341ef3-33ab-481f-9a5a-9d7c10f78c14	ERROR	Error: Special numeric value NaN is not allowed
    at convertToNumberAttr (/var/runtime/node_modules/@aws-sdk/util-dynamodb/dist-cjs/index.js:212:11)
    at convertToAttr (/var/runtime/node_modules/@aws-sdk/util-dynamodb/dist-cjs/index.js:120:12)
    at marshall (/var/runtime/node_modules/@aws-sdk/util-dynamodb/dist-cjs/index.js:307:26)
    at marshallFunc (/var/runtime/node_modules/@aws-sdk/lib-dynamodb/dist-cjs/index.js:130:97)
    at processObj (/var/runtime/node_modules/@aws-sdk/lib-dynamodb/dist-cjs/index.js:69:14)
    at /var/runtime/node_modules/@aws-sdk/lib-dynamodb/dist-cjs/index.js:122:28
    at Array.reduce (<anonymous>)
    at processAllKeysInObj (/var/runtime/node_modules/@aws-sdk/lib-dynamodb/dist-cjs/index.js:118:30)
    at processObj (/var/runtime/node_modules/@aws-sdk/lib-dynamodb/dist-cjs/index.js:78:16)
    at processKeysInObj (/var/runtime/node_modules/@aws-sdk/lib-dynamodb/dist-cjs/index.js:107:28)

@lpsinger lpsinger requested review from Courey and dakota002 December 10, 2024 16:55
@lpsinger lpsinger marked this pull request as draft December 10, 2024 16:59
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 6.08%. Comparing base (05c0611) to head (ed63237).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
app/routes/circulars/circulars.server.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main   #2776      +/-   ##
========================================
- Coverage   6.08%   6.08%   -0.01%     
========================================
  Files        171     171              
  Lines       4337    4340       +3     
  Branches     474     476       +2     
========================================
  Hits         264     264              
- Misses      4071    4074       +3     
  Partials       2       2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lpsinger lpsinger marked this pull request as ready for review December 10, 2024 17:04
Fixes the following error:

```
2024-12-10T16:45:51.373Z	96341ef3-33ab-481f-9a5a-9d7c10f78c14	ERROR	Error: Special numeric value NaN is not allowed
    at convertToNumberAttr (/var/runtime/node_modules/@aws-sdk/util-dynamodb/dist-cjs/index.js:212:11)
    at convertToAttr (/var/runtime/node_modules/@aws-sdk/util-dynamodb/dist-cjs/index.js:120:12)
    at marshall (/var/runtime/node_modules/@aws-sdk/util-dynamodb/dist-cjs/index.js:307:26)
    at marshallFunc (/var/runtime/node_modules/@aws-sdk/lib-dynamodb/dist-cjs/index.js:130:97)
    at processObj (/var/runtime/node_modules/@aws-sdk/lib-dynamodb/dist-cjs/index.js:69:14)
    at /var/runtime/node_modules/@aws-sdk/lib-dynamodb/dist-cjs/index.js:122:28
    at Array.reduce (<anonymous>)
    at processAllKeysInObj (/var/runtime/node_modules/@aws-sdk/lib-dynamodb/dist-cjs/index.js:118:30)
    at processObj (/var/runtime/node_modules/@aws-sdk/lib-dynamodb/dist-cjs/index.js:78:16)
    at processKeysInObj (/var/runtime/node_modules/@aws-sdk/lib-dynamodb/dist-cjs/index.js:107:28)
```
@dakota002 dakota002 merged commit c7607d5 into nasa-gcn:main Dec 11, 2024
12 checks passed
@lpsinger lpsinger deleted the 404-nan branch December 12, 2024 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants