Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for import breaking ci #2047

Closed
wants to merge 1 commit into from
Closed

Conversation

dakota002
Copy link
Contributor

No description provided.

@dakota002 dakota002 requested review from lpsinger and Courey March 7, 2024 14:18
@dakota002 dakota002 mentioned this pull request Mar 7, 2024
@lpsinger
Copy link
Member

lpsinger commented Mar 7, 2024

This was my fault --- I rebased trussworks/react-uswds#2726 and pushed ad2ea23 to update our package-lock.json file. I should have made a PR. I'll revert that.

Meanwhile, could this be a regression in react-uswds? Do you know why this is no longer working?

@dakota002
Copy link
Contributor Author

Not sure. From what I can tell the ButtonProps are not included as an export in their index.d.ts. I just deleted the import and did a ctrl+. to see where vs code would find it. I will see if they made a recent change that affects this

lpsinger added a commit to lpsinger/gcn.nasa.gov that referenced this pull request Mar 7, 2024
@dakota002 dakota002 deleted the ImportFix branch May 7, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants