snake_case and ra_dec_error #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpsinger
requested changes
Mar 5, 2024
Duplicated with alert, due to case-insensitive issue in git
Got duplicated, due to case-insensitive issue in git!
Got duplicated, due to case-insensitive issue in git!
Got duplicated, due to case-insensitive issue in git!
Done. It looked like was related with case-insensitive filename in GitHub. |
lpsinger
approved these changes
Mar 5, 2024
aam97
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two corrections were needed:
(a) We use snake_case convention (CamelCase is for Core Schema), thus all schema should begin with a lowercase letters.
(b) Uncertainty property is updated as ra_dec_error in Localization Core Schema.
(In continuation of #130 ...)