Adding count rate in core #127
Conversation
Co-authored-by: Leo Singer <[email protected]>
|
@jracusin please check this PR. |
| @@ -9,6 +9,14 @@ | |||
| "type": "number", | |||
| "description": "False alarm rate: the rate of occurrence of non-astrophysical events that are of the same intensity or significance as the current event [Hz]" | |||
| }, | |||
| "net_count_rate": { | |||
| "type": "number", | |||
| "description": "Net count rate of the transient above the background [counts/s]" | |||
There was a problem hiding this comment.
The description should specify that this is over the rate_duration and rate_energy_range.
| }, | ||
| "backgound_count_rate": { | ||
| "type": "number", | ||
| "description": "Count rate of the background for the transient [counts/s]" |
There was a problem hiding this comment.
Same comment about rate_duration and rate_energy_range as in the net_count_rate.
| }, | ||
| "backgound_count_rate": { | ||
| "type": "number", | ||
| "description": "Count rate of the background for the transient [counts/s] over rate_duration and rate_energy_range." |
There was a problem hiding this comment.
| "description": "Count rate of the background for the transient [counts/s] over rate_duration and rate_energy_range." | |
| "description": "Count rate of the background for the transient [counts/s] over backgound rate duration and rate energy range." |
There was a problem hiding this comment.
@jracusin we can't use same rate_duration property for the background. However we can add background time range array.
There was a problem hiding this comment.
The background rate comes from using multiple intervals, but it is used to estimate the background during the source interval. I think this use is fine.
| "backgound_count_rate": { | ||
| "type": "number", | ||
| "description": "Count rate of the background for the transient [counts/s] over rate_duration and rate_energy_range." | ||
| }, |
There was a problem hiding this comment.
I do not think we need to include this.
|
@jracusin background time intervals removed. Is everything else approved? |
Vidushi-GitHub
force-pushed
the
vidushi/counts
branch
from
9119fdc to
e84f4da
Compare
|
Rebasing had some issues and we should notify these changes to Einstein Probe soon, so opened a new PR #136 and closing this. |
One property of the Einstein Probe is useful for various missions - net count rate.
However, it requires a consistent definition for other teams as well.
Example, some teams report count/s with background subtraction, others report count rates with background.
To ensure consistency, it would be beneficial for the GCN team to standardize this property.