-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include null as option for p-values #108
Conversation
…s) can be null. This happens when a search is not run for selection reasons, or an individual event is not significant in one search or the other.
Is it OK to just omit the field when it is unknown, rather than set it to null? If so, then no changes are needed. |
Our preference is to use these nulls to indicate things that aren't reported, but if you would prefer not to use nulls, let us know and we will adapt. |
For IceCube specific-fields in schema, it's producer's preference. |
Thanks all, is it possible to get a new stable tag for the schema issued? @Vidushi-GitHub or @lpsinger ? |
Sure. @dakota002, are there any other changes to include in the next release? |
@lpsinger Two changes total: (a) Only number to union for core/follow-up schema, not breaking for existing IceCube/Guano and also, works well for new IceCube. (b) Ice-Cube LVK schema @dakota002 |
I think that we ought to do a major version bump. |
2.0.0 or 2.0.1? as, core and patch change |
No, just a major version change, 2.0.0. |
Stable tag v2.0.0 is there @blaufuss. @dakota002 @lpsinger |
Thanks, much appreciated. |
Make it clear that p-values reported (overall search or per-event one…s) can be null. This happens when a search is not run for selection reasons, or an individual event is not significant in one search or the other.