Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include null as option for p-values #108

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

blaufuss
Copy link
Contributor

Make it clear that p-values reported (overall search or per-event one…s) can be null. This happens when a search is not run for selection reasons, or an individual event is not significant in one search or the other.

…s) can be null. This happens when a search is not run for selection reasons, or an individual event is not significant in one search or the other.
@lpsinger
Copy link
Member

Is it OK to just omit the field when it is unknown, rather than set it to null? If so, then no changes are needed.

@blaufuss
Copy link
Contributor Author

Our preference is to use these nulls to indicate things that aren't reported, but if you would prefer not to use nulls, let us know and we will adapt.

@Vidushi-GitHub
Copy link
Member

For IceCube specific-fields in schema, it's producer's preference.

@lpsinger lpsinger merged commit 65be7fd into nasa-gcn:main Sep 25, 2023
@blaufuss
Copy link
Contributor Author

Thanks all, is it possible to get a new stable tag for the schema issued? @Vidushi-GitHub or @lpsinger ?

@lpsinger
Copy link
Member

Sure. @dakota002, are there any other changes to include in the next release?

@Vidushi-GitHub
Copy link
Member

Vidushi-GitHub commented Sep 26, 2023

@lpsinger Two changes total: (a) Only number to union for core/follow-up schema, not breaking for existing IceCube/Guano and also, works well for new IceCube. (b) Ice-Cube LVK schema @dakota002

@lpsinger
Copy link
Member

I think that we ought to do a major version bump.

@Vidushi-GitHub
Copy link
Member

I think that we ought to do a major version bump.

2.0.0 or 2.0.1? as, core and patch change

@lpsinger
Copy link
Member

No, just a major version change, 2.0.0.

@Vidushi-GitHub
Copy link
Member

Stable tag v2.0.0 is there @blaufuss. @dakota002 @lpsinger

@blaufuss
Copy link
Contributor Author

Stable tag v2.0.0 is there @blaufuss. @dakota002 @lpsinger

Thanks, much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants