Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a try to run the validate in the produce method #16

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

dakota002
Copy link
Contributor

No description provided.

@dakota002 dakota002 requested a review from lpsinger March 15, 2023 20:11
Copy link
Member

@lpsinger lpsinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My philosophy so far has been that this package concerns itself only with Kafka client configuration presets and that it is a thin and transparent wrapper around the official Kafka client.

@dakota002
Copy link
Contributor Author

That's fair. With the updates to the schemas we should have a step somewhere in the chain of events that enforces the validation of the data being submitted. Maybe this validation step could exist in the broker then?

@lpsinger
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants