Skip to content

Commit

Permalink
Remove oauth_cb workaround for KIP-768 support
Browse files Browse the repository at this point in the history
  • Loading branch information
lpsinger committed Dec 4, 2024
1 parent 110db61 commit 72aca78
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 77 deletions.
12 changes: 0 additions & 12 deletions gcn_kafka/core.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@
import confluent_kafka
import confluent_kafka.admin

from .oidc import set_oauth_cb


def get_config(mode, config, **kwargs):
# Merge configuration from user.
Expand Down Expand Up @@ -46,7 +44,6 @@ def get_config(mode, config, **kwargs):
if mode == "producer":
config.setdefault("compression.type", "zstd")

set_oauth_cb(config)
return config


Expand Down Expand Up @@ -81,9 +78,6 @@ def __init__(
**kwargs,
)
)
# Workaround for https://github.com/confluentinc/librdkafka/issues/3753#issuecomment-1058272987.
# FIXME: Remove once fixed upstream, or on removal of oauth_cb.
self.poll(0)


class Consumer(confluent_kafka.Consumer):
Expand Down Expand Up @@ -111,9 +105,6 @@ def __init__(
**kwargs,
)
)
# Workaround for https://github.com/confluentinc/librdkafka/issues/3753#issuecomment-1058272987.
# FIXME: Remove once fixed upstream, or on removal of oauth_cb.
self.poll(0)


class AdminClient(confluent_kafka.admin.AdminClient):
Expand Down Expand Up @@ -141,6 +132,3 @@ def __init__(
**kwargs,
)
)
# Workaround for https://github.com/confluentinc/librdkafka/issues/3753#issuecomment-1058272987.
# FIXME: Remove once fixed upstream, or on removal of oauth_cb.
self.poll(0)
30 changes: 0 additions & 30 deletions gcn_kafka/oidc.py

This file was deleted.

33 changes: 0 additions & 33 deletions gcn_kafka/test/test_oidc.py

This file was deleted.

2 changes: 0 additions & 2 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,8 @@ classifiers = [
"Topic :: System :: Networking"
]
dependencies = [
"authlib",
"certifi",
"confluent-kafka >= 2.2.0",
"requests",
]
requires-python = ">=3.9"
dynamic = [ "version" ]
Expand Down

0 comments on commit 72aca78

Please sign in to comment.