Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nw.Series could not be pickled #1488

Merged
merged 8 commits into from
Dec 2, 2024

Conversation

MarcoGorelli
Copy link
Member

closes #1486

What type of PR is this? (check all applicable)

  • πŸ’Ύ Refactor
  • ✨ Feature
  • πŸ› Bug Fix
  • πŸ”§ Optimization
  • πŸ“ Documentation
  • βœ… Test
  • 🐳 Other

Related issues

  • Related issue #<issue number>
  • Closes #<issue number>

Checklist

  • Code follows style guide (ruff)
  • Tests added
  • Documented the changes

If you have comments or can explain your changes, please do so below

@MarcoGorelli MarcoGorelli changed the title Pickling fix: nw.Series could not be pickled Dec 2, 2024
@github-actions github-actions bot added the fix label Dec 2, 2024
@MarcoGorelli MarcoGorelli marked this pull request as ready for review December 2, 2024 21:45
@MarcoGorelli MarcoGorelli merged commit 37638d2 into narwhals-dev:main Dec 2, 2024
23 of 24 checks passed
level=obj._level,
)
if isinstance(obj, NwLazyFrame):
return LazyFrame(
obj._compliant_frame._change_dtypes(dtypes),
obj._compliant_frame._change_dtypes(Version.V1),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function needs renaming - will do so tomorrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: pandas-backed nw.Series can't be pickled in dataclass.asdict
1 participant