Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch: fix dtypes rendering #1481

Merged
merged 2 commits into from
Dec 1, 2024
Merged

patch: fix dtypes rendering #1481

merged 2 commits into from
Dec 1, 2024

Conversation

FBruzzesi
Copy link
Member

What type of PR is this? (check all applicable)

  • πŸ’Ύ Refactor
  • ✨ Feature
  • πŸ› Bug Fix
  • πŸ”§ Optimization
  • πŸ“ Documentation
  • βœ… Test
  • 🐳 Other

Related issues

Should we consider closing #1077?

Checklist

  • Code follows style guide (ruff)
  • Tests added
  • Documented the changes

If you have comments or can explain your changes, please do so below

Noticed that Int16 was not rendering properly. I used to opportunity to add descriptions to other types

image

Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @FBruzzesi !

i think there's still some left without docstrings, or at least without examples, let's address those before closing

@MarcoGorelli MarcoGorelli merged commit 8966bba into main Dec 1, 2024
24 checks passed
@FBruzzesi FBruzzesi deleted the docs/dtypes-docstrings branch December 1, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants