Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: remove cudf from import hooks #1445

Merged

Conversation

raisadz
Copy link
Contributor

@raisadz raisadz commented Nov 25, 2024

What type of PR is this? (check all applicable)

  • πŸ’Ύ Refactor
  • ✨ Feature
  • πŸ› Bug Fix
  • πŸ”§ Optimization
  • πŸ“ Documentation
  • βœ… Test
  • 🐳 Other

Related issues

  • Related issue #<issue number>
  • Closes #<issue number>

Checklist

  • Code follows style guide (ruff)
  • Tests added
  • Documented the changes

If you have comments or can explain your changes, please do so below

The cuDF tests for is_pandas_dataframe were failing.

Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks so much @raisadz , it looks like their import hook works differently to fireducks', in that if we run

import pandas as pd
print(type(pd.DataFrame({'a': [1,2,3]})))

with python -m cudf.pandas, then we get <class 'pandas.core.frame.DataFrame'>, whereas for fireducks we'd get fireducks.pandas.DataFrame

@raisadz raisadz marked this pull request as ready for review November 25, 2024 15:27
@MarcoGorelli MarcoGorelli merged commit 6cb6c6f into narwhals-dev:main Nov 25, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants