Skip to content

Commit

Permalink
raise pandas_pyarrow
Browse files Browse the repository at this point in the history
  • Loading branch information
FBruzzesi committed Nov 15, 2024
1 parent bfd35a9 commit 898b51f
Showing 1 changed file with 13 additions and 1 deletion.
14 changes: 13 additions & 1 deletion tests/expr_and_series/cum_min_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import pytest

import narwhals.stable.v1 as nw
from tests.utils import PANDAS_VERSION
from tests.utils import PYARROW_VERSION
from tests.utils import Constructor
from tests.utils import ConstructorEager
Expand All @@ -23,6 +24,9 @@ def test_cum_min_expr(request: pytest.FixtureRequest, constructor: Constructor)
if PYARROW_VERSION < (13, 0, 0) and "pyarrow_table" in str(constructor):
request.applymarker(pytest.mark.xfail)

if PANDAS_VERSION < (2, 2) and "pandas_pyarrow" in str(constructor):
request.applymarker(pytest.mark.xfail)

df = nw.from_native(constructor(data))
result = df.select(
cum_min=nw.col("a").cum_min(),
Expand All @@ -32,7 +36,15 @@ def test_cum_min_expr(request: pytest.FixtureRequest, constructor: Constructor)
assert_equal_data(result, expected)


def test_cum_min_series(constructor_eager: ConstructorEager) -> None:
def test_cum_min_series(
request: pytest.FixtureRequest, constructor_eager: ConstructorEager
) -> None:
if PYARROW_VERSION < (13, 0, 0) and "pyarrow_table" in str(constructor_eager):
request.applymarker(pytest.mark.xfail)

if PANDAS_VERSION < (2, 2) and "pandas_pyarrow" in str(constructor_eager):
request.applymarker(pytest.mark.xfail)

df = nw.from_native(constructor_eager(data), eager_only=True)
result = df.select(
cum_min=df["a"].cum_min(),
Expand Down

0 comments on commit 898b51f

Please sign in to comment.