Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix jar -> directory output and add test from #89 #91

Merged
merged 1 commit into from
Sep 21, 2024
Merged

Fix jar -> directory output and add test from #89 #91

merged 1 commit into from
Sep 21, 2024

Conversation

sencrash
Copy link
Contributor

No description provided.

EpicPlayerA10
EpicPlayerA10 requested changes Sep 21, 2024
View reviewed changes
Copy link
Collaborator

@EpicPlayerA10 EpicPlayerA10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You thrown a SnakeGame jar but not obfuscated.

The rest looks good to me.

@sencrash
Copy link
Contributor Author

You thrown a SnakeGame jar but not obfuscated.

The rest looks good to me.

Ah, forgot to put it back

EpicPlayerA10
EpicPlayerA10 requested changes Sep 21, 2024
View reviewed changes
Copy link
Collaborator

@EpicPlayerA10 EpicPlayerA10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more thing: Rename jar to original name SnakeGame-obf-zkm.jar for readability that this jar was obfuscated using zkm.

EpicPlayerA10
EpicPlayerA10 approved these changes Sep 21, 2024
View reviewed changes
Copy link
Collaborator

@EpicPlayerA10 EpicPlayerA10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much :D

@EpicPlayerA10 EpicPlayerA10 merged commit ebf4732 into narumii:master Sep 21, 2024
1 of 2 checks passed
@EpicPlayerA10 EpicPlayerA10 mentioned this pull request Sep 21, 2024
Closed
@sencrash sencrash deleted the custom-jar branch September 21, 2024 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EpicPlayerA10 EpicPlayerA10 EpicPlayerA10 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sencrash @EpicPlayerA10