add no peers test for eos.get_bgp_neighbors

napalm-automation · Jul 16, 2024 · b7a2c13 · b7a2c13
1 parent 5bb8d0e
commit b7a2c13
Show file tree

Hide file tree

Showing 6 changed files with 48 additions and 1 deletion.
diff --git a/napalm/eos/eos.py b/napalm/eos/eos.py
@@ -729,7 +729,6 @@ def get_bgp_neighbors(self) -> Dict[str, models.BGPStateNeighborsPerVRFDict]:
                         ),
                         "sent_prefixes": peer["v6PrefixesSent"],
                     }
-                    vrf["router_id"] = napalm.base.helpers.ip(peer["localRouterId"])
                     peer_data: models.BGPStateNeighborDict = {
                         "local_as": local_as,
                         "remote_as": remote_as,
@@ -744,6 +743,14 @@ def get_bgp_neighbors(self) -> Dict[str, models.BGPStateNeighborsPerVRFDict]:
                         },
                     }
                     vrf["peers"][peer_ip] = peer_data
+
+        # Iterate IPv4 and IPv6 summary details for router-id assignment
+        for cmd in cmd_outputs[:2]:
+            for vrf_name, vrf_data in cmd["vrfs"].items():
+                bgp_counters[vrf_name]["router_id"] = napalm.base.helpers.ip(
+                    vrf_data["routerId"]
+                )
+
         bgp_counters["global"] = bgp_counters.pop("default")
         return dict(bgp_counters)
 

diff --git a/test/eos/mocked_data/test_get_bgp_neighbors/nopeers/expected_result.json b/test/eos/mocked_data/test_get_bgp_neighbors/nopeers/expected_result.json
@@ -0,0 +1,6 @@
+{
+  "global": {
+    "peers": {},
+    "router_id": "192.168.0.0"
+  }
+}
diff --git a/test/eos/mocked_data/test_get_bgp_neighbors/nopeers/show_ip_bgp_neighbors_vrf_all.json b/test/eos/mocked_data/test_get_bgp_neighbors/nopeers/show_ip_bgp_neighbors_vrf_all.json
@@ -0,0 +1,7 @@
+{
+  "vrfs": {
+    "default": {
+      "peerList": []
+    }
+  }
+}
diff --git a/test/eos/mocked_data/test_get_bgp_neighbors/nopeers/show_ip_bgp_summary_vrf_all.json b/test/eos/mocked_data/test_get_bgp_neighbors/nopeers/show_ip_bgp_summary_vrf_all.json
@@ -0,0 +1,10 @@
+{
+  "vrfs": {
+    "default": {
+      "vrf": "default",
+      "routerId": "192.168.0.0",
+      "asn": "65001",
+      "peers": {}
+    }
+  }
+}
diff --git a/test/eos/mocked_data/test_get_bgp_neighbors/nopeers/show_ipv6_bgp_peers_vrf_all.json b/test/eos/mocked_data/test_get_bgp_neighbors/nopeers/show_ipv6_bgp_peers_vrf_all.json
@@ -0,0 +1,7 @@
+{
+  "vrfs": {
+    "default": {
+      "peerList": []
+    }
+  }
+}
diff --git a/test/eos/mocked_data/test_get_bgp_neighbors/nopeers/show_ipv6_bgp_summary_vrf_all.json b/test/eos/mocked_data/test_get_bgp_neighbors/nopeers/show_ipv6_bgp_summary_vrf_all.json
@@ -0,0 +1,10 @@
+{
+  "vrfs": {
+    "default": {
+      "vrf": "default",
+      "routerId": "192.168.0.0",
+      "asn": "65001",
+      "peers": {}
+    }
+  }
+}