Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump python version to 3.8 #44

Merged
merged 4 commits into from
Nov 16, 2023
Merged

Conversation

vhaasteren
Copy link
Member

@vhaasteren vhaasteren commented Nov 16, 2023

This drops support for python 3.7. The 'isort' package we use for pre-commit-hooks doesn't support python 3.7 anymore either, causing issues with our integration tests. The isort package is updated to version 5.12.0, because there was a bug with the way it processes our pyproject.toml file.

@vhaasteren vhaasteren requested a review from kdolum November 16, 2023 10:55
@vhaasteren
Copy link
Member Author

Hi @kdolum, if you review/approve and merge this one into master, and then merge master into your own PR #41, then your PR will also be passing all the tests.

Then I can approve it.

Copy link
Collaborator

@kdolum kdolum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good. It's unfortunate that python is a moving target, but we have to move along with it.

@kdolum kdolum merged commit 992d66d into nanograv:master Nov 16, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants