Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed find_empty_masks for CMX #1872

Merged
merged 7 commits into from
Dec 12, 2024
Merged

Fixed find_empty_masks for CMX #1872

merged 7 commits into from
Dec 12, 2024

Conversation

dlakaplan
Copy link
Contributor

model.find_empty_masks did not search through CMX parameters. Now it does.

@dlakaplan dlakaplan added bug fix Bug fixing pull request awaiting review This PR needs someone to review it so it can be merged minor A minor PR that doesn't need a lot of thought labels Dec 10, 2024
@mtlam
Copy link
Member

mtlam commented Dec 10, 2024

Changes look good to me, thanks again for handling this.

@dlakaplan
Copy link
Contributor Author

Previously the validation needed >=1 TOA such that (R1<=TOA) && (TOA<T2), but the actual selection in toa_select has (R1<=TOA) && (TOA<=T2), so I changed the validation to follow that.

@abhisrkckl abhisrkckl merged commit a990a53 into nanograv:master Dec 12, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
awaiting review This PR needs someone to review it so it can be merged bug fix Bug fixing pull request minor A minor PR that doesn't need a lot of thought
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dlakaplan @mtlam @abhisrkckl