Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Brute force method to find the optimal number of harmonics for WaveX, DMWaveX, and CMWaveX #1822

Closed
wants to merge 43 commits into from

Conversation

abhisrkckl
Copy link
Contributor

@abhisrkckl abhisrkckl commented Aug 9, 2024

Also moves [CM|DM]WaveX-related functions out of pint.utils (see #1804)

This PR depends on #1802, so it should be merged before merging this.

@abhisrkckl abhisrkckl linked an issue Aug 9, 2024 that may be closed by this pull request
Copy link

codecov bot commented Aug 9, 2024

Codecov Report

Attention: Patch coverage is 69.62233% with 185 lines in your changes missing coverage. Please review.

Project coverage is 69.56%. Comparing base (8c9a689) to head (b66d989).
Report is 33 commits behind head on master.

Files Patch % Lines
src/pint/models/wavex.py 56.15% 35 Missing and 22 partials ⚠️
src/pint/noise_analysis.py 66.25% 51 Missing and 3 partials ⚠️
src/pint/models/cmwavex.py 80.69% 25 Missing and 14 partials ⚠️
src/pint/models/dmwavex.py 58.53% 13 Missing and 4 partials ⚠️
src/pint/models/timing_model.py 76.05% 12 Missing and 5 partials ⚠️
src/pint/utils.py 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1822      +/-   ##
==========================================
+ Coverage   69.48%   69.56%   +0.07%     
==========================================
  Files         108      110       +2     
  Lines       25106    25411     +305     
  Branches     4455     4515      +60     
==========================================
+ Hits        17445    17676     +231     
- Misses       6549     6611      +62     
- Partials     1112     1124      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abhisrkckl abhisrkckl closed this Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Utility function for noise model selection
1 participant