Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type hints in residuals.py & bump black to 24.x #1817

Merged
merged 8 commits into from
Aug 9, 2024

Conversation

abhisrkckl
Copy link
Contributor

No description provided.

@abhisrkckl abhisrkckl changed the title Type hints in residuals.py Type hints in residuals.py & bump black to 24.x Aug 7, 2024
@abhisrkckl abhisrkckl added awaiting review This PR needs someone to review it so it can be merged minor A minor PR that doesn't need a lot of thought labels Aug 8, 2024
@dlakaplan
Copy link
Contributor

Do we need to bump black now? I thought the annual updates happened in Jan, so maybe we are just very late?

@abhisrkckl
Copy link
Contributor Author

We were using black 23 in tox.ini and black 24 in the pre-commit file. It was working till now for some reason.
But black 24.8 dropped last week, breaking the black CI test for this PR. Bumping the black version was the only way to make it work.

I think we should be bumping the black version anyway, and this is as good a time as any, in my opinion.

@abhisrkckl
Copy link
Contributor Author

#1709

@dlakaplan
Copy link
Contributor

OK, that makes sense.

@dlakaplan
Copy link
Contributor

I can merge this when you are set.

@abhisrkckl
Copy link
Contributor Author

This is ready to go.

@dlakaplan dlakaplan merged commit 3dd6f6c into nanograv:master Aug 9, 2024
7 checks passed
@abhisrkckl abhisrkckl mentioned this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review This PR needs someone to review it so it can be merged minor A minor PR that doesn't need a lot of thought
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants