Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More typehints #1813

Merged
merged 15 commits into from
Aug 9, 2024
Merged

More typehints #1813

merged 15 commits into from
Aug 9, 2024

Conversation

dlakaplan
Copy link
Contributor

No description provided.

@dlakaplan dlakaplan changed the title WIP: adding more typehints More typehints Aug 7, 2024
@abhisrkckl
Copy link
Contributor

This looks good. Shall I merge this?

@abhisrkckl
Copy link
Contributor

PLease add a CHANGELOG entry. There is already a line in CHANGELOG-unreleased.rst about type hints, maybe you can update that.

@abhisrkckl
Copy link
Contributor

#1709

@dlakaplan
Copy link
Contributor Author

Sorry - I had made a CHANGELOG entry but just forgot to push it. Done now.

@dlakaplan dlakaplan added the awaiting review This PR needs someone to review it so it can be merged label Aug 9, 2024
@abhisrkckl abhisrkckl merged commit 840cf96 into nanograv:master Aug 9, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review This PR needs someone to review it so it can be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants