Improve clock error reporting #1720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1720 +/- ##
=======================================
Coverage 68.96% 68.97%
=======================================
Files 105 105
Lines 24696 24697 +1
Branches 4409 4409
=======================================
+ Hits 17031 17034 +3
+ Misses 6560 6559 -1
+ Partials 1105 1104 -1 ☔ View full report in Codecov by Sentry. |
aarchiba
added
enhancement
awaiting review
|
Looks good to me. Is this ready for merging? |
|
Yes, it's ready to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When PINT tries to read a clock file with out-of-order entries, it will raise an exception. (Such files have never worked correctly on any of TEMPO, TEMPO2, or PINT.) This PR makes sure that includes the first two out-of-order MJDs to aid in diagnosing the problem.
Helped with both ipta/pulsar-clock-corrections#18 and ipta/pulsar-clock-corrections#19