Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plot model DM in pintk + more tests for pintk #1678

Merged
merged 13 commits into from
Dec 18, 2023

Conversation

abhisrkckl
Copy link
Contributor

@abhisrkckl abhisrkckl commented Nov 15, 2023

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (7896a55) 68.41% compared to head (f4f4c6e) 68.51%.
Report is 27 commits behind head on master.

❗ Current head f4f4c6e differs from pull request most recent head 7f6843a. Consider uploading reports for the commit 7f6843a to get more accurate results

Files Patch % Lines
src/pint/pintk/plk.py 11.11% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1678      +/-   ##
==========================================
+ Coverage   68.41%   68.51%   +0.09%     
==========================================
  Files         104      104              
  Lines       24339    24348       +9     
  Branches     4346     4349       +3     
==========================================
+ Hits        16651    16681      +30     
+ Misses       6600     6575      -25     
- Partials     1088     1092       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abhisrkckl abhisrkckl changed the title WIP: More tests for pintk Plot model DM in pintk + more tests for pintk Dec 6, 2023
@abhisrkckl
Copy link
Contributor Author

image

@dlakaplan
Copy link
Contributor

Does this behave properly for data with no DM or just a constant DM?

@abhisrkckl
Copy link
Contributor Author

It works for constant DM:
image

The "model DM" radio buttons should be disabled when there is no dispersion component. I'll fix this.

@abhisrkckl
Copy link
Contributor Author

abhisrkckl commented Dec 8, 2023

Does this behave properly for data with no DM

OK.. fixed this.
image

Please ignore the bad timing residuals. I deleted DM from the par file.

@dlakaplan
Copy link
Contributor

great

@dlakaplan
Copy link
Contributor

I'm confused by that screenshot: it looks to have 2 y-axis labels

@abhisrkckl
Copy link
Contributor Author

I'm confused by that screenshot: it looks to have 2 y-axis labels

That seems to be an unrelated bug. It shows up even without the changes in this PR.

@dlakaplan
Copy link
Contributor

Can you figure out how to reproduce to file a separate issue?

@dlakaplan dlakaplan merged commit 47026ba into nanograv:master Dec 18, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pintk should somehow allow plotting of DMX values for narrow-band data
2 participants