-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize usage of astropy.units #1644
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1644 +/- ##
==========================================
+ Coverage 68.55% 68.60% +0.04%
==========================================
Files 103 103
Lines 23528 23564 +36
Branches 4102 4113 +11
==========================================
+ Hits 16130 16165 +35
+ Misses 6381 6378 -3
- Partials 1017 1021 +4
☔ View full report in Codecov by Sentry. |
If you want to do this, then I think https://nanograv-pint.readthedocs.io/en/latest/coding-style.html should be updated accordingly so we have a record of what to do. |
Closing this because this is a superset of #1643, and that was found to be inadequate. |
#1641
This is a superset of #1643.
So this should be merged only after merging #1643.
I am doing it this way to make sure that the performance comparisons are meaningful.