Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plot wideband DMs and DM residuals in pintk #1534

Merged
merged 17 commits into from
Nov 17, 2023

Conversation

abhisrkckl
Copy link
Contributor

@abhisrkckl abhisrkckl commented Feb 14, 2023

Implements #1430

Three new plotting options: WB DM, WB DM res, WB DM err. These are disabled for narrowband data.

Also fixes a bug introduced in #1663, and fixes a broken import.

@codecov
Copy link

codecov bot commented Feb 14, 2023

Codecov Report

Attention: 33 lines in your changes are missing coverage. Please review.

Comparison is base (7c14b7b) 68.47% compared to head (b5d095d) 68.40%.
Report is 1 commits behind head on master.

Files Patch % Lines
src/pint/pintk/plk.py 5.88% 32 Missing ⚠️
src/pint/pintk/pulsar.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1534      +/-   ##
==========================================
- Coverage   68.47%   68.40%   -0.08%     
==========================================
  Files         104      104              
  Lines       24305    24336      +31     
  Branches     4337     4345       +8     
==========================================
+ Hits        16644    16646       +2     
- Misses       6574     6603      +29     
  Partials     1087     1087              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abhisrkckl
Copy link
Contributor Author

DM Measurements:
image

DM Residuals:
image

DM Errors:
image

These new radio buttons are disabled for narrowband data.
image

@abhisrkckl abhisrkckl changed the title WIP: Plot wideband DMs and DM residuals in pintk Plot wideband DMs and DM residuals in pintk Nov 6, 2023
@abhisrkckl abhisrkckl added the awaiting review This PR needs someone to review it so it can be merged label Nov 8, 2023
@dlakaplan dlakaplan merged commit c2c9434 into nanograv:master Nov 17, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review This PR needs someone to review it so it can be merged enhancement GUI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Visualize DM model and/or DM residuals for wideband data (using pintk?)
2 participants