-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Script to export clock files #1373
Open
dlakaplan
wants to merge
4
commits into
nanograv:master
Choose a base branch
from
dlakaplan:clockexport
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
import argparse | ||
import os | ||
import sys | ||
|
||
import pint.logging | ||
from loguru import logger as log | ||
|
||
pint.logging.setup(level=pint.logging.script_level) | ||
|
||
import pint.observatory | ||
import pint.observatory.topo_obs | ||
|
||
__all__ = ["main"] | ||
|
||
|
||
def main(argv=None): | ||
parser = argparse.ArgumentParser( | ||
description="PINT tool for export clock files", | ||
formatter_class=argparse.ArgumentDefaultsHelpFormatter, | ||
epilog=f"Example: export_clocks -o clock_dir/ GBT Arecibo CHIME VLA", | ||
) | ||
parser.add_argument( | ||
"observatories", help="Observatories to export", type=str, nargs="+" | ||
) | ||
parser.add_argument( | ||
"-o", | ||
"--out", | ||
default=os.path.abspath(os.curdir), | ||
type=str, | ||
dest="directory", | ||
help="Destination directory (set $PINT_CLOCK_OVERRIDE to this value to look here first for clock files)", | ||
) | ||
parser.add_argument( | ||
"--log-level", | ||
type=str, | ||
choices=("TRACE", "DEBUG", "INFO", "WARNING", "ERROR"), | ||
default="WARNING", | ||
help="Logging level", | ||
dest="loglevel", | ||
) | ||
args = parser.parse_args(argv) | ||
pint.logging.setup(level=args.loglevel) | ||
if not os.path.isdir(args.directory): | ||
log.error(f"Destination {args.directory} is not a directory") | ||
sys.exit(1) | ||
|
||
for obsname in args.observatories: | ||
obs = pint.observatory.get_observatory(obsname) | ||
obs._load_clock_corrections() | ||
|
||
pint.observatory.topo_obs.export_all_clock_files(args.directory) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More conventional would be a
--verbose
(possibly repeatable) and optionally a--quiet
rather than explicitly referencing log levels. Since this is a specific application, one might be able to select sensible log levels to correspond to these.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's the type of interface I had gone for initially for applications, but @scottransom wanted this method
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit confused... What does
--verbose
have to do with a specified output directory or filename?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And if the discussion is about the log levels, I was just thinking that we should be consistent with the other PINT command line programs. Maybe
--verbose
could correspond to upping the log level by one, as well. (maybe by one for each verbose added).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is about log levels. I'm not sure users of a command line program will have any idea what log levels have to do with what output they want to see. Making
--verbose
bump up the log level, and--quiet
bump it down by one might be a tidy way to present a more conventional command-line interface.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is what I had implemented months ago. I agree it's more standard but I don't really care either way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #1377 for discussion of this.