-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: persist pickles for TOAs loaded during a test run #1336
base: master
Are you sure you want to change the base?
Conversation
This PR is inevitably going to conflict with #1305 so perhaps best not to do too much until that is merged. |
Codecov Report
@@ Coverage Diff @@
## master #1336 +/- ##
==========================================
- Coverage 61.31% 61.27% -0.05%
==========================================
Files 89 90 +1
Lines 20218 20366 +148
Branches 3619 3653 +34
==========================================
+ Hits 12397 12479 +82
- Misses 7046 7103 +57
- Partials 775 784 +9
Continue to review full report at Codecov.
|
Key TODO item: compare full-test-suite runtime with |
Currently many of our tests load TOAs from files in
tests/datafile/
. Some of these files are quite large. PINT has a facility for making re-loading of tim files much faster: saving a pickle in which clock corrections and similar data have already been computed. This PR is intended to make the test suite use this facility, where appropriate, by creating these pickles in a temporary directory that persists for the duration of a test run.This PR also add the ability to easily specify a directory in which pickles should be kept, named according to the name of the .tim files they are made from. This may be useful in other contexts.
This PR needs to convert many old
unittest
-style test cases so that they can usepytest
fixtures. Minor test cleanups may also happen.