Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reoarganize pint.utils #1804

Open
abhisrkckl opened this issue Jul 11, 2024 · 1 comment
Open

Reoarganize pint.utils #1804

abhisrkckl opened this issue Jul 11, 2024 · 1 comment

Comments

@abhisrkckl
Copy link
Contributor

pint.utils is a whopping 3285 lines long without any organization. It's a bunch of widely different functions thrown together. We should reorganize it by

  1. Splitting it into multiple files
  2. Moving some of the functions into more sensible locations. For example, wavex_setup and dmwavex_setup should be in the pint.models.[dm]wavex namespace, IMO.
@scottransom
Copy link
Member

Just putting a not here about it, but your post reminded me that I've been intending on making a PR to rename get_conjunction() in pint.utils. That name is way too ambiguous. Needs to be something like get_solar_conjunction().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants