AWS Signature Version 4 #149

networkfusion · 2023-08-14T00:51:33Z

Description

Adds AWS Signature Version 4, this can be used instead of TLS certificates and will be required for supporting MQTT over WebSockets and HTTP Client support.

If can also be used for other AWS capabilities (e.g. S3 buckets).

It is not fully tested and could probably be optimized, but this is a major attempt towards support.

Motivation and Context

Builds upon #148

How Has This Been Tested?

Screenshots

Types of changes

Improvement (non-breaking change that improves a feature, code or algorithm)
Bug fix (non-breaking change which fixes an issue with code or algorithm)
New feature (non-breaking change which adds functionality to code)
Breaking change (fix or feature that would cause existing functionality to change)
Config and build (change in the configuration and build system, has no impact on code or features)
Dependencies (update dependencies and changes associated, has no impact on code or features)
Unit Tests (add new Unit Test(s) or improved existing one(s), has no impact on code or features)
Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

My code follows the code style of this project (only if there are changes in source code).
My changes require an update to the documentation (there are changes that require the docs website to be updated).
I have updated the documentation accordingly (the changes require an update on the docs in this repo).
I have read the CONTRIBUTING document.
I have tested everything locally and all new and existing tests passed (only if there are changes in source code).
I have added new tests to cover my changes.

Ellerbach

Few comments

nanoFramework.Aws.IoTCore.Devices/AwsSignatureVersion4/nfArrayListExtensions.cs

Ellerbach · 2023-08-14T07:30:01Z

nanoFramework.Aws.IoTCore.Devices/AwsSignatureVersion4/nfArrayListExtensions.cs

+        /// </summary>
+        /// <param name="items">Items in the ArrayList</param>
+        /// <param name="comparer">The Comparer</param>
+        public static void Sort(this ArrayList items, IComparer comparer)


now I get your question on Discord :-)

Why not using a quick-sort algorithm? It's fast and simple: https://www.geeksforgeeks.org/quick-sort/
You even have it implemented directly in C# there.

Thanks, I will look into that as a later optimization. Given it is currently working as expected (in the context of my pesudo tests matching full fat .Net), I would rather not mess with it until appropriate unit tests are added and fully end to end tested.

sonarcloud · 2023-08-23T18:15:20Z

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
24 Code Smells

No Coverage information
12.0% Duplication

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Before we get real dirty.

Re-comment out un-necessary classes

sonarcloud · 2024-05-02T20:42:32Z

Quality Gate failed

Failed conditions
12.0% Duplication on New Code (required ≤ 5%)

See analysis details on SonarCloud

coderabbitai · 2024-08-10T15:52:49Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

sonarcloud · 2024-08-10T16:23:52Z

Quality Gate failed

Failed conditions
12.0% Duplication on New Code (required ≤ 5%)

See analysis details on SonarCloud

networkfusion force-pushed the add-sigv4 branch from 7c76652 to 9cc3e09 Compare August 14, 2023 01:54

Ellerbach reviewed Aug 14, 2023

View reviewed changes

networkfusion added 8 commits April 9, 2024 22:50

Add sigv4 initial commit

5c41b96

Before we get real dirty.

Convert to nF

71e6320

Re-comment out un-necessary classes

Update nuget.

6ed5a94

Uncomment other SigV4 classes.

91b8121

Update nanoFramework.Aws.IoTCore.Devices.nuspec

80a6939

Split classes into separate files

ac4a368

Fix some sonar warnings.

f3a1c7d

Work on tests.

c284ebd

networkfusion force-pushed the add-sigv4 branch from 151b519 to c284ebd Compare April 9, 2024 22:01

networkfusion added 3 commits April 9, 2024 23:01

Update nugets

8316673

Update nuspec

c566466

Merge branch 'main' into add-sigv4

5309f28

Update nugets

a95896f

networkfusion added 2 commits August 10, 2024 17:02

Update nanoFramework.Aws.IoTCore.Devices.nuspec

279ef86

Merge branch 'main' into add-sigv4

a85b3b6

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

AWS Signature Version 4 #149

AWS Signature Version 4 #149

networkfusion commented Aug 14, 2023 •

edited

Loading

Ellerbach left a comment

Ellerbach Aug 14, 2023

networkfusion Aug 15, 2023

sonarcloud bot commented Aug 23, 2023

sonarcloud bot commented May 2, 2024

coderabbitai bot commented Aug 10, 2024

Review skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

sonarcloud bot commented Aug 10, 2024

AWS Signature Version 4 #149

Are you sure you want to change the base?

AWS Signature Version 4 #149

Conversation

networkfusion commented Aug 14, 2023 • edited Loading

Description

Motivation and Context

How Has This Been Tested?

Screenshots

Types of changes

Checklist:

Ellerbach left a comment

Choose a reason for hiding this comment

Ellerbach Aug 14, 2023

Choose a reason for hiding this comment

networkfusion Aug 15, 2023

Choose a reason for hiding this comment

sonarcloud bot commented Aug 23, 2023

sonarcloud bot commented May 2, 2024

Quality Gate failed

coderabbitai bot commented Aug 10, 2024

Review skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

sonarcloud bot commented Aug 10, 2024

Quality Gate failed

networkfusion commented Aug 14, 2023 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)