Implement nannou::geom::path::Builder end
method
#908
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
nannou::geom::path::Builder
doesn't expose the internallyon::path::path::Builder
'send
method, which leads to validation panics when a path is built outside of release mode. Reproducable example (must be run without--release
, Lyon's path validator is turned off if the flag is enabled):Since Lyon's
Builder::end
isn't exposed by Nannou, the only clearly documented way out is withclose
, but that's undesirable as it forces a closed loop. A workaround for this is to usepath.inner_mut().end(false);
, but for convenience this PR adds it to the Builder directly.Requiring paths to be properly ended before
build
was added in Lyon v0.17. I see that anend
method was correctly added with the version bump, but it wasn't published.Resolves #933