Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement public Error types using thiserror #892

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

frankplow
Copy link

This PR implements the Error trait for DrawError using the derive macro provided by thiserror. This requires adding the thiserror dependency to nannou. This is in keeping with how Errors are implemented elsewhere in the project however - thiserror is already used in nannou_audio, nannou_laser and nannou_isf.

@frankplow frankplow changed the title Implement Error for DrawError using thiserror Implement public Error types using thiserror Oct 24, 2022
@frankplow
Copy link
Author

742b86b extends the thiserror approach to the other public Error types from nannou. This reduces boilerplate and increases consistency across the codebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant