Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: breakpoints #473

Closed
wants to merge 6 commits into from

Conversation

happytomatoe
Copy link
Contributor

@happytomatoe happytomatoe commented Sep 17, 2024

TODO:

  • Fix bug when adding breakpoint causes editor to scroll up
  • Add breakpoints to CPU Emulator
  • Add breakpoints to test runner
  • Implement change when breakpoints should be cleared when a user uploads a file
  • Add empty breakpoint - When a user presses on a function declaration simulation won't stop there - Won't do
  • Handle a case when a user changes the code. In some cases simulator won't stop on a breakpoint - Probably won't do also
  • Tests?

@happytomatoe
Copy link
Contributor Author

Looks like speed is changed after adding a breakpoint in runbar

@happytomatoe
Copy link
Contributor Author

As it turned out that - as timer gets recreated, runbar also gets recreated. And after runbar creating it doesn't set the speed. So basically when I set a breakpoint timer uses default speed(1000). I've added a hotfix so that runbar sets the speed after being created

@happytomatoe
Copy link
Contributor Author

Would be great if someone could go over components as I see that they are recreated 3-5 times

@happytomatoe
Copy link
Contributor Author

I don't have time for this now

@happytomatoe happytomatoe reopened this Sep 19, 2024
@happytomatoe
Copy link
Contributor Author

I am building the wrong feature. Old java CPU emulator has what is called watchpoint in eclipse. VSCode doesn' have this feature. I didn't even know that this exists. What a smart person built this feature! I won't continues building breakpoints feature. I don't think that people need it.
Currently I am trying to solve a specific issue - when I try to run a game, written in Jack, inside CPU emulator stack pointer goes into negative values. Watchpoint is an amazing tool to troubleshoot this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant