Align project file structure with software suite #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netalondon
force-pushed
the
project-structure-update
branch
from
c0f7b51 to
1ab5692
Compare
DavidSouther
requested changes
Jul 31, 2024
| @@ -25,7 +25,7 @@ describe("All Projects", () => { | |||
| )("Builtin %s", async (chipName) => { | |||
| // eslint-disable-next-line @typescript-eslint/ban-ts-comment | |||
| // @ts-ignore | |||
| const ChipProject = ChipProjects[project]?.CHIPS[chipName]; | |||
| const ChipProject = ChipProjects[project]?.CHIPS; | |||
| let hdlFile: string = ChipProject?.[`${chipName}.hdl`]; | |||
There was a problem hiding this comment.
I think you can drop the ?. access as well?
There was a problem hiding this comment.
Sorry, I meant below in the ChipProject?. parts
netalondon
force-pushed
the
project-structure-update
branch
from
da3d0a5 to
84ad58e
Compare
DavidSouther
approved these changes
Jul 31, 2024
| @@ -25,7 +25,7 @@ describe("All Projects", () => { | |||
| )("Builtin %s", async (chipName) => { | |||
| // eslint-disable-next-line @typescript-eslint/ban-ts-comment | |||
| // @ts-ignore | |||
| const ChipProject = ChipProjects[project]?.CHIPS[chipName]; | |||
| const ChipProject = ChipProjects[project]?.CHIPS; | |||
| let hdlFile: string = ChipProject?.[`${chipName}.hdl`]; | |||
There was a problem hiding this comment.
Sorry, I meant below in the ChipProject?. parts
netalondon
force-pushed
the
project-structure-update
branch
from
fb9f353 to
edf0325
Compare
DavidSouther
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.