Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bitmap editor url in service worker #394

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Fix bitmap editor url in service worker #394

merged 1 commit into from
Jul 9, 2024

Conversation

netalondon
Copy link
Collaborator

No description provided.

@netalondon netalondon requested a review from DavidSouther July 8, 2024 09:39
@netalondon
Copy link
Collaborator Author

@DavidSouther I think this could be the cause for #391 but I haven't been able to replicate it yet.
Should I close #391 in that case?

DavidSouther
DavidSouther reviewed Jul 8, 2024
View reviewed changes
Copy link
Collaborator

@DavidSouther DavidSouther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how this would resolve #391?

web/src/service-worker.ts Show resolved Hide resolved
@netalondon netalondon force-pushed the bug/bitmap-editor-url branch from b0baa16 to 6023203 Compare July 8, 2024 14:42
@DavidSouther DavidSouther merged commit 5bd67a4 into nand2tetris:main Jul 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidSouther DavidSouther DavidSouther approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@netalondon @DavidSouther