improve coverage

najaeda · Mar 26, 2024 · 0c289c0 · 0c289c0
1 parent e0f06ea
commit 0c289c0
Show file tree

Hide file tree

Showing 4 changed files with 31 additions and 2 deletions.
diff --git a/src/snl/snl/kernel/SNLBusTerm.h b/src/snl/snl/kernel/SNLBusTerm.h
@@ -55,8 +55,11 @@ class SNLBusTerm final: public SNLTerm {
     SNLName getName() const override { return name_; }
     bool isAnonymous() const override { return name_.empty(); }
     void setName(const SNLName& name) override;
-    const char* getTypeName() const override;
+
     SNLTerm::Direction getDirection() const override { return direction_; }
+    void setDirection(const SNLTerm::Direction& direction) { direction_ = direction; }
+
+    const char* getTypeName() const override;
     std::string getString() const override;
     std::string getDescription() const override;
     void debugDump(size_t indent, bool recursive=true, std::ostream& stream=std::cerr) const override;

diff --git a/src/snl/snl/kernel/SNLNetComponent.h b/src/snl/snl/kernel/SNLNetComponent.h
@@ -26,6 +26,7 @@ class SNLNetComponent: public SNLDesignObject {
         };
         Direction(const DirectionEnum& dirEnum);
         Direction(const Direction& direction) = default;
+        Direction& operator=(const Direction& direction) = default;
         operator const DirectionEnum&() const {return dirEnum_;}
         std::string getString() const;
         private:

diff --git a/src/snl/snl/kernel/SNLScalarTerm.h b/src/snl/snl/kernel/SNLScalarTerm.h
@@ -29,6 +29,8 @@ class SNLScalarTerm final: public SNLBitTerm {
     NajaCollection<SNLBitTerm*> getBits() const override;
 
     SNLTerm::Direction getDirection() const override { return direction_; }
+    void setDirection(const SNLTerm::Direction& direction) { direction_ = direction; }
+
     const char* getTypeName() const override;
     std::string getString() const override;
     std::string getDescription() const override;

diff --git a/test/snl/snl/kernel/SNLInstanceSetModelTest.cpp b/test/snl/snl/kernel/SNLInstanceSetModelTest.cpp
@@ -97,7 +97,7 @@ TEST_F(SNLInstanceSetModelTest, testAnonymousContradictionError) {
   EXPECT_THROW(ins0_->setModel(newModel), SNLException);  
 }
 
-TEST_F(SNLInstanceSetModelTest, testDifferentNetNameError) {
+TEST_F(SNLInstanceSetModelTest, testDifferentTermNameError) {
   //clone model
   auto newModel = model_->clone();
   ASSERT_NE(newModel, nullptr);
@@ -108,6 +108,29 @@ TEST_F(SNLInstanceSetModelTest, testDifferentNetNameError) {
   EXPECT_THROW(ins0_->setModel(newModel), SNLException);  
 }
 
+TEST_F(SNLInstanceSetModelTest, testDifferentTermIDError) {
+  //clone model
+  auto newModel = model_->clone();
+  ASSERT_NE(newModel, nullptr);
+  ASSERT_EQ(5, newModel->getTerms().size());
+  auto term4 = newModel->getScalarTerm(SNLName("term4"));
+  ASSERT_NE(nullptr, term4);
+  term4->destroy();
+  SNLScalarTerm::create(newModel, SNLID::DesignObjectID(9), SNLTerm::Direction::InOut, SNLName("term4"));
+  EXPECT_THROW(ins0_->setModel(newModel), SNLException);  
+}
+
+TEST_F(SNLInstanceSetModelTest, testDifferentTermDirectionError) {
+  //clone model
+  auto newModel = model_->clone();
+  ASSERT_NE(newModel, nullptr);
+  ASSERT_EQ(5, newModel->getTerms().size());
+  auto term3 = newModel->getBusTerm(SNLName("term3"));
+  ASSERT_NE(nullptr, term3);
+  term3->setDirection(SNLTerm::Direction::Input);
+  EXPECT_THROW(ins0_->setModel(newModel), SNLException);  
+}
+
 TEST_F(SNLInstanceSetModelTest, testDifferentSizeBusError) {
   //clone model
   auto newModel = model_->clone();