Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: doc hold Client for the app lifetime, log WARN 'connection health check failed' #223

Merged
merged 1 commit into from
Apr 20, 2024
Merged

chore: doc hold Client for the app lifetime, log WARN 'connection health check failed' #223

merged 1 commit into from
Apr 20, 2024

Conversation

CherishCai
Copy link
Collaborator

chore:

  • doc hold Client for the app lifetime,
  • log WARN 'connection health check failed'

@CherishCai CherishCai added documentation Improvements or additions to documentation chore Chore for code labels Apr 20, 2024
@CherishCai CherishCai requested a review from onewe April 20, 2024 11:59
@onewe
Copy link
Collaborator

onewe commented Apr 20, 2024

LGTM

@onewe onewe merged commit fc2bddb into main Apr 20, 2024
5 checks passed
@CherishCai CherishCai deleted the chore_doc_and_log_clear branch May 16, 2024 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onewe onewe Awaiting requested review from onewe

Assignees
No one assigned
Labels
chore Chore for code documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CherishCai @onewe