Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VC周り #306

Merged
merged 14 commits into from
Dec 4, 2023
Merged

VC周り #306

merged 14 commits into from
Dec 4, 2023

Conversation

na2na-p
Copy link
Owner

@na2na-p na2na-p commented Nov 13, 2023 •
edited
Loading

VC参加、VC退出をできるようにした

テストあまりにもつら過ぎなのでvitestに移行

na2na-p
na2na-p commented Nov 13, 2023
View reviewed changes
.tool-versions Show resolved Hide resolved
@na2na-p na2na-p marked this pull request as ready for review November 13, 2023 15:10
@na2na-p na2na-p changed the base branch from topic/project-init to v3 November 13, 2023 15:11
@na2na-p na2na-p marked this pull request as draft November 13, 2023 15:11
@na2na-p na2na-p marked this pull request as ready for review November 13, 2023 15:12
@na2na-p na2na-p force-pushed the topic/vc branch 3 times, most recently from c57202d to fc053dd Compare November 20, 2023 07:42
@na2na-p
Copy link
Owner Author

na2na-p commented Nov 20, 2023

Mock連打酷いのでどこかでDIできるようなリファクタやります

@na2na-p
Copy link
Owner Author

na2na-p commented Nov 20, 2023

このPRがマージされた後でやること

  • DI
  • ディレクトリ整理

@na2na-p na2na-p force-pushed the topic/vc branch 3 times, most recently from 0b8ff89 to 0573b90 Compare November 22, 2023 05:48
@na2na-p na2na-p requested a review from haminem December 4, 2023 13:09
@na2na-p na2na-p enabled auto-merge December 4, 2023 13:10
haminem
haminem approved these changes Dec 4, 2023
View reviewed changes
Copy link
Collaborator

@haminem haminem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3点解決したらLGTM！

@na2na-p na2na-p merged commit e2605aa into v3 Dec 4, 2023
6 checks passed
@na2na-p na2na-p deleted the topic/vc branch December 4, 2023 13:13
@na2na-p na2na-p mentioned this pull request Jan 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haminem haminem haminem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@na2na-p @haminem