Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

プロジェクト作成 #303

Merged
merged 30 commits into from
Dec 4, 2023
Merged

プロジェクト作成 #303

merged 30 commits into from
Dec 4, 2023

Conversation

na2na-p
Copy link
Owner

@na2na-p na2na-p commented Nov 11, 2023 •
edited
Loading

  • テストができる
  • ESLintが使える
  • ping - pongができる

image
image
image

na2na-p
na2na-p commented Nov 11, 2023
View reviewed changes
.tool-versions Outdated Show resolved Hide resolved
loader.mjs Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
package.json Show resolved Hide resolved
src/features/core/internal/Client.ts Outdated Show resolved Hide resolved
src/index.ts Show resolved Hide resolved
@na2na-p
Copy link
Owner Author

na2na-p commented Nov 11, 2023 •
edited
Loading

@haminem

レビューに対する修正、本PRだけ例外的に 別PR で対応させてください！

@na2na-p na2na-p enabled auto-merge November 22, 2023 06:28
haminem
haminem approved these changes Dec 4, 2023
View reviewed changes
Copy link
Collaborator

@haminem haminem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！

@na2na-p na2na-p merged commit 6cf37a3 into v3 Dec 4, 2023
6 checks passed
@na2na-p na2na-p deleted the topic/project-init branch December 4, 2023 12:39
na2na-p
na2na-p commented Dec 4, 2023
View reviewed changes
src/features/core/internal/Client/internal/Client.class.ts
import type { ClassConstructorArgs } from './Client.types.js';

export class Client extends DiscordJsClient {
readonly #config;
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

型注釈つける

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haminem haminem haminem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@na2na-p @haminem