Skip to content

Commit

Permalink
packageNameの厳格化
Browse files Browse the repository at this point in the history
  • Loading branch information
na2na-p committed Nov 27, 2023
1 parent 8c0a447 commit 5d17605
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 7 deletions.
4 changes: 1 addition & 3 deletions .github/workflows/cd-for-v3-main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,12 +28,10 @@ jobs:
echo "JETDISC_VERSION=$(cat package.json | jq -r '.version')" >> $GITHUB_ENV
- name: Check Docker Hub
id: check_docker_hub
# NOTE: 実験用にすでに存在しててもOUTPUT吐き出す
run: |
DOCKER_HUB_TAGS=$(curl -s ${{ env.DOCKER_TAG_API_URI }} | jq -r '.results[] | .name')
if [ $(echo $DOCKER_HUB_TAGS | grep -c $JETDISC_VERSION) -eq 1 ]; then
echo "Tag $JETDISC_VERSION already exists on Docker Hub."
echo "JETDISC_VERSION=$JETDISC_VERSION" >> $GITHUB_OUTPUT
else
echo "Tag $JETDISC_VERSION does not exist on Docker Hub."
echo "tag_exists=false" >> $GITHUB_OUTPUT
Expand All @@ -51,7 +49,7 @@ jobs:
Build-and-Push-to-Docker-Hub:
needs:
- Prepare
# if: ${{ needs.Prepare.outputs.tag_exists == 'false' }}
if: ${{ needs.Prepare.outputs.tag_exists == 'false' }}
with:
JETDISC_VERSION: ${{ needs.Prepare.outputs.JETDISC_VERSION }}
IMAGE_REPOSITORY: na2na
Expand Down
2 changes: 1 addition & 1 deletion infra/k8s/helm/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 3.0.0-helm-beta1
version: 3.0.0-helm

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
Expand Down
2 changes: 1 addition & 1 deletion infra/k8s/helm/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ replicaCount: 1

image:
repository: na2na/jetdisc
tag: ee16d9e
tag: 3.0.0
registry: docker.io
pullPolicy: IfNotPresent

Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "jetdisc",
"version": "3.0.0-beta1",
"version": "3.0.0",
"description": "",
"type": "module",
"main": "built/index.js",
Expand Down
2 changes: 1 addition & 1 deletion renovate.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
},
{
"datasources": ["docker"],
"packageNames": ["na2na/jetdisc"],
"packageNames": ["docker.io/na2na/jetdisc"],
"matchManagers": ["helm-values"]
}
]
Expand Down

0 comments on commit 5d17605

Please sign in to comment.