PipeParser Enhancements - Fix issues related to unexpected segments. #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lated to unexpected Segments * Also includes tests, inluding tests for classes which previously had none
milkshakeuk
added
enhancement
defect
|
@AMCN41R could you have a look when you get a sec? |
This comment has been minimized.
This comment has been minimized.
milkshakeuk
force-pushed
the
PipeParserEnhancements
branch
from
35c808a
to
0a71e31
Compare
…ation with @JlKmn
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
AMCN41R
reviewed
Apr 15, 2021
tests/NHapi.NUnit/Parser/LegacyPipePipeParserLargeEmbeddedFileTest.cs
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
milkshakeuk
force-pushed
the
PipeParserEnhancements
branch
from
d0afcf2
to
0f4bf3f
Compare
This comment has been minimized.
This comment has been minimized.
Unit Test Results 5 files 101 suites 14s ⏱️ Results for commit a4fb37d. |
milkshakeuk
removed
the
defect
AMCN41R
approved these changes
Apr 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #101 and possibly others.
PipeParserfrom hapi.PipeParserto become theLegacyPipeParserin case people have already coded around its issues and desire to keep its behaviour.PipeParser.