Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added max_tokens check and support for non-OpenAI models #614

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Added max_tokens check and support for non-OpenAI models #614

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 27 additions & 17 deletions bot/openai_helper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -624,23 +624,31 @@ async def __summarise(self, conversation) -> str:

def __max_model_tokens(self):
base = 4096
max_tokens = 0
if self.config['model'] in GPT_3_MODELS:
return base
if self.config['model'] in GPT_3_16K_MODELS:
return base * 4
if self.config['model'] in GPT_4_MODELS:
return base * 2
if self.config['model'] in GPT_4_32K_MODELS:
return base * 8
if self.config['model'] in GPT_4_VISION_MODELS:
return base * 31
if self.config['model'] in GPT_4_128K_MODELS:
return base * 31
if self.config['model'] in GPT_4O_MODELS:
return base * 31
raise NotImplementedError(
f"Max tokens for model {self.config['model']} is not implemented yet."
)
max_tokens = base
elif self.config['model'] in GPT_3_16K_MODELS:
max_tokens = base * 4
elif self.config['model'] in GPT_4_MODELS:
max_tokens = base * 2
elif self.config['model'] in GPT_4_32K_MODELS:
max_tokens = base * 8
elif self.config['model'] in GPT_4_VISION_MODELS:
max_tokens = base * 31
elif self.config['model'] in GPT_4_128K_MODELS:
max_tokens = base * 31
elif self.config['model'] in GPT_4O_MODELS:
max_tokens = base * 31
else:
logging.warning(
f"Max tokens for model {self.config['model']} is not implemented yet."
)
max_tokens = 200000

if self.config['max_tokens'] >= max_tokens:
raise Exception(f"max_tokens {self.config['max_tokens']} should be less than max tokens {max_tokens} for model {self.config['model']}.")

return max_tokens

# https://github.com/openai/openai-cookbook/blob/main/examples/How_to_count_tokens_with_tiktoken.ipynb
def __count_tokens(self, messages) -> int:
Expand All @@ -662,7 +670,9 @@ def __count_tokens(self, messages) -> int:
tokens_per_message = 3
tokens_per_name = 1
else:
raise NotImplementedError(f"""num_tokens_from_messages() is not implemented for model {model}.""")
tokens_per_message = 3
tokens_per_name = 1
logging.warn(f"""num_tokens_from_messages() is not implemented for model {model}.""")
num_tokens = 0
for message in messages:
num_tokens += tokens_per_message
Expand Down