Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimisation of the parallelCompactMap implementation #20

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Optimisation of the parallelCompactMap implementation #20

wants to merge 1 commit into from

Conversation

mz2
Copy link
Owner

@mz2 mz2 commented Nov 22, 2021

  • Removes an unnecessary sort from the parallelCompactMap implementation.
  • Removes some dead, commented out code.

@mz2
Simplifies the parallelCompactMap implementation by removing an unn…
be0ebcc 
…ecessary sort

Removes some commented out code.
@mz2
Copy link
Owner Author

mz2 commented Nov 22, 2021

Rather than merging this, you could also take the updated implementation from here and incorporate into Bento, @markuspiipari. The function is not used (nor tested) in Carpaccio right now at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markuspiipari markuspiipari Awaiting requested review from markuspiipari

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mz2