Don't crash when passed a null client id #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes a client can get confused, and start sending messages with null client ids. This just avoids crashing when that happens.
You need to provide callbacks to redis commands or else redis will throw an error (killing your process) when something goes wrong.
When a client is subscribed to channels like /foo/* and /foo/bar, and a message is published to /foo/bar, the client should only receive *one* message. Previously, we were sending the message for every shard each subscribed channel lived in. (So if /foo/* was in shard1 and /foo/bar was in shard2, the subscriber would get two copies.) This change collects all the client ids from all shards and only sends one message to each client.
Pulled in "async" to help with several cases where we perform several operations in parallel, and need a callback at the end.
Ported from faye-redis-node, see: https://github.com/jpignata/faye-redis-node/commit/d0bc94086315ddbffbcf68018df4e0019eb3c632
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes a client can get confused, and start sending messages with
null client ids. This just avoids crashing when that happens.